Don't require in-line play text to start with list

[bshephar]

This change removes the webhook validation requirement that in-line plays need to be lists. A play in Ansible is a dict, while a playbook is a list of plays. This change ensures we validate on the play format to conform with the terminology in use. For reference, see: https://github.com/ansible/ansible/blob/devel/test/units/playbook/test_play.py\#L48

Given the terminology we use in the OpenStackDataPlaneService of 'play', we should then validate on the Ansible defined 'play' format, rather than a 'playbook' format.

Depends-On: openstack-k8s-operators/install_yamls#835

[bshephar]

See the following thread for reference:
openstack-k8s-operators/dataplane-operator#871 (comment)

[rabi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bshephar,rabi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rabi]

In the commit message you wrote Don't require in-line playbooks to start with list .. These are inline plays not playbooks.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@bshephar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ansibleee-operator-build-deploy-kuttl	4c4ca5a	link	true	/test ansibleee-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ed580333ea79457e9b82f4034af7345f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 42m 36s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 47m 15s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 28m 45s
✔️ ansibleee-operator-docs-preview SUCCESS in 2m 20s

[bshephar]

Need to change the repo-setup service in CI to keep this moving now:

❯ curl -s https://logserver.rdoproject.org/62/362/4c4ca5a0794fc389c8851005b673a81292a9aa82/github-check/podified-multinode-edpm-deployment-crc/bbef286/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/crs/openstackdataplanedeployments.dataplane.openstack.org/edpm-deployment.yaml | yq '.status.conditions[0].message'
Deployment error occurred nodeSet: openstack-edpm-ipam error: admission webhook "vopenstackansibleee.kb.io" denied the request: OpenStakAnsibleEE.ansibleee.openstack.org "repo-setup-edpm-deployment-openstack-edpm-ipam" is invalid: spec.play: Invalid value: "- hosts: all\n  strategy: linear\n  tasks:\n    - name: Enable podified-repos\n      become: true\n      ansible.builtin.shell: |\n        set -euxo pipefail\n        pushd /var/tmp\n        curl -sL https://github.com/openstack-k8s-operators/repo-setup/archive/refs/heads/main.tar.gz | tar -xz\n        pushd repo-setup-main\n        python3 -m venv ./venv\n        PBR_VERSION=0.0.0 ./venv/bin/pip install ./\n        # This is required for FIPS enabled until trunk.rdoproject.org\n        # is not being served from a centos7 host, tracked by\n        # https://issues.redhat.com/browse/RHOSZUUL-1517\n        update-crypto-policies --set FIPS:NO-ENFORCE-EMS\n        ./venv/bin/repo-setup current-podified -b antelope\n        popd\n        rm -rf repo-setup-main\n": error checking sanity of an inline play: - hosts: all
  strategy: linear
  tasks:
    - name: Enable podified-repos
      become: true
      ansible.builtin.shell: |
        set -euxo pipefail
        pushd /var/tmp
        curl -sL https://github.com/openstack-k8s-operators/repo-setup/archive/refs/heads/main.tar.gz | tar -xz
        pushd repo-setup-main
        python3 -m venv ./venv
        PBR_VERSION=0.0.0 ./venv/bin/pip install ./
        # This is required for FIPS enabled until trunk.rdoproject.org
        # is not being served from a centos7 host, tracked by
        # https://issues.redhat.com/browse/RHOSZUUL-1517
        update-crypto-policies --set FIPS:NO-ENFORCE-EMS
        ./venv/bin/repo-setup current-podified -b antelope
        popd
        rm -rf repo-setup-main
 Key: '' Error:Field validation for '' failed on the 'play' tag

[bshephar]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/452320578fc140dcbe9b0acbe7356d4f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 27s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 45m 01s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 38m 21s
✔️ ansibleee-operator-docs-preview SUCCESS in 2m 21s

[bshephar]

The more I think about this, the more I think we shouldn't change it. It's nice to be able to provide an entire in-line playbook. Even if the terminology isn't technically correct, I think I prefer the functionality if we just allow users to provide entire playbooks.

[bshephar]

I'm closing this. We need to change the terminology rather than the implementation. We pass this to the RUNNER_PLAYBOOK env var, which expects a playbook, not a play. So the interface terminology needs changing rather than the implementation.