Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADDITIONAL_NAMESPACES environment variable #30

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Dec 11, 2023

We might need to gather logs from more namespaces when we execute the openstack-must-gather tool in CI.
For this reason this patch introduces an ADDITIONAL_NAMESPACES environment variable to collect the list of the namespaces relevant for CI.

We might need to gather logs from more namespaces when we execute the
must-gather in CI.
For this reason this patch introduces an ADDITIONAL_NAMESPACES environment
variable to collect the list of the namespaces relevant for CI.

Signed-off-by: Francesco Pantano <[email protected]>
@fmount fmount requested review from pablintino and hjensas and removed request for stuggi and frenzyfriday December 11, 2023 13:22
Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2d13e00 into openstack-k8s-operators:main Dec 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants