Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aodh, logging and metric-storage services #36

Conversation

vyzigold
Copy link
Contributor

@vyzigold vyzigold commented Jan 3, 2024

This PR adds aodh, logging and metric-storage to the list of services to gather their configuration secrets.

@openshift-ci openshift-ci bot requested review from olliewalsh and viroel January 3, 2024 19:58
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/24fc484cfc0f4286b9926a05494d2052

podified-multinode-edpm-deployment-crc NODE_FAILURE Node request 100-0006788507 failed in 0s

@vyzigold vyzigold marked this pull request as draft January 3, 2024 20:07
@vyzigold
Copy link
Contributor Author

vyzigold commented Jan 3, 2024

I also added *.monitoring.rhobs to the gathered CRs, which are CRs created by telemetry-operator for metric storage

@vyzigold vyzigold marked this pull request as ready for review January 3, 2024 20:51
@openshift-ci openshift-ci bot requested a review from stuggi January 3, 2024 20:52
collection-scripts/gather_crs Outdated Show resolved Hide resolved
@vyzigold vyzigold requested a review from fmount January 10, 2024 07:22
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 10, 2024
Copy link

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c882a2f into openstack-k8s-operators:main Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants