-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally dump the openstack databases #37
Optionally dump the openstack databases #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this feature, I have some comments inline
This patch introduces the ability to specify an environment variable with a list of openstack databases that should be dumped. It is also possible to set the variable to "ALL", which results in trigger the mysqldump command with the --all-databases option. By default the OPENSTACK_DATABASES variables is unset and this flow is entirely skipped. To enable it, the aforementioned variable should be explicitly set. Signed-off-by: Francesco Pantano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cd0a486
into
openstack-k8s-operators:main
This patch introduces the ability to specify an environment variable with a list of
openstack
databases that should be dumped. It is also possible to set the variable toALL
, which results in trigger themysqldump
command with the--all-databases
option. By default theOPENSTACK_DATABASES
variables isunset
and this flow is entirely skipped.To enable it, the aforementioned variable should be explicitly set.