Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally dump the openstack databases #37

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Jan 8, 2024

This patch introduces the ability to specify an environment variable with a list of openstack databases that should be dumped. It is also possible to set the variable to ALL, which results in trigger the mysqldump command with the --all-databases option. By default the OPENSTACK_DATABASES variables is unset and this flow is entirely skipped.
To enable it, the aforementioned variable should be explicitly set.

@fmount fmount requested a review from lewisdenny January 8, 2024 10:24
@openshift-ci openshift-ci bot requested review from Akrog and olliewalsh January 8, 2024 10:24
Copy link
Contributor

@Akrog Akrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature, I have some comments inline

collection-scripts/gather_db Outdated Show resolved Hide resolved
collection-scripts/gather_db Outdated Show resolved Hide resolved
collection-scripts/gather_db Outdated Show resolved Hide resolved
collection-scripts/gather_db Outdated Show resolved Hide resolved
This patch introduces the ability to specify an environment variable
with a list of openstack databases that should be dumped. It is also
possible to set the variable to "ALL", which results in trigger the
mysqldump command with the --all-databases option.
By default the OPENSTACK_DATABASES variables is unset and this flow
is entirely skipped. To enable it, the aforementioned variable should
be explicitly set.

Signed-off-by: Francesco Pantano <[email protected]>
Copy link
Contributor

@Akrog Akrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2024
@fmount fmount added the approved label Jan 8, 2024
Copy link

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cd0a486 into openstack-k8s-operators:main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants