Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some basic collection for octavia service details #43

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

beagles
Copy link
Contributor

@beagles beagles commented Feb 29, 2024

Patch adds some basic data collection of octavia resources. Missing is some extra detail dumps that involve looping over output of previous commands.

@beagles beagles changed the title Add some basic colleciton for octavia service details Add some basic collection for octavia service details Feb 29, 2024
@fmount fmount requested review from fmount, Akrog and lewisdenny March 2, 2024 09:47
@beagles beagles marked this pull request as ready for review March 4, 2024 13:34
@openshift-ci openshift-ci bot requested review from olliewalsh and viroel March 4, 2024 13:35
Patch adds some basic data collection of octavia resources.
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a0f6eab into openstack-k8s-operators:main Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants