Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch ssh private key secret #84

Conversation

amartyasinha
Copy link
Contributor

@amartyasinha amartyasinha commented Feb 6, 2025

Current issues:

  • ssh-privatekey under data was not under the scope of masking.
  • last-applied-configuration which is under metadata was also not under the scope of masking.

This PR aims to fix both issues. A new _applyMask method is added to do recursive call over secrets which are part of metadata.

Testing:
Currently, the python script was directly tested against a k8s secret dump and it was able to mask ssh-privatekey within data and metadata. It has not been tested as a part of a job.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ac38549d869a44b49622d032d4bcd591

podified-multinode-edpm-deployment-crc RETRY_LIMIT in 3m 06s

@amartyasinha amartyasinha marked this pull request as draft February 6, 2025 14:03
@amartyasinha amartyasinha force-pushed the patch-ssh-private-key-secret branch from 547fb56 to 4533664 Compare February 6, 2025 14:05
@amartyasinha amartyasinha marked this pull request as ready for review February 6, 2025 14:06
@openshift-ci openshift-ci bot requested review from abays and lewisdenny February 6, 2025 14:06
Copy link

@frenzyfriday frenzyfriday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@amartyasinha amartyasinha force-pushed the patch-ssh-private-key-secret branch from 257d216 to 07d5e10 Compare February 6, 2025 16:47
Copy link

@pablintino pablintino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The content in the must-gather output seems to be fine. I'm fine with the change.

Copy link

@frenzyfriday frenzyfriday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frenzyfriday

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 7, 2025
@frenzyfriday
Copy link

/approved

@openshift-merge-bot openshift-merge-bot bot merged commit 4a2d985 into openstack-k8s-operators:main Feb 7, 2025
4 checks passed
@pablintino
Copy link

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@pablintino: new pull request created: #85

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants