-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch ssh private key secret #84
Patch ssh private key secret #84
Conversation
…ave sensitive info
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ac38549d869a44b49622d032d4bcd591 ❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 3m 06s |
547fb56
to
4533664
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
257d216
to
07d5e10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The content in the must-gather output seems to be fine. I'm fine with the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frenzyfriday The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/approved |
4a2d985
into
openstack-k8s-operators:main
/cherry-pick 18.0-fr1 |
@pablintino: new pull request created: #85 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Current issues:
ssh-privatekey
under data was not under the scope of masking.metadata
was also not under the scope of masking.This PR aims to fix both issues. A new
_applyMask
method is added to do recursive call over secrets which are part ofmetadata
.Testing:
Currently, the python script was directly tested against a k8s secret dump and it was able to mask
ssh-privatekey
withindata
andmetadata
. It has not been tested as a part of a job.