testing something, please ignore. #277
Conversation
When a workflow is set without ExtraConfigMap in ansible controller the pod won't be able to start because the pointer won't be pointing at nothing. Changed the condition to allow avoiding this issue. not tested, waiting for a test enviornment to work on this Jira: https://issues.redhat.com/browse/OSPRH-11191
…39-to-18.0-fr1 [18.0-fr1] Fix the nil pointing issue
This patch fixes the issue when ExtraConfigmapsMounts is empty. Dereferencing a nil pointer leads to a panic. We now first check whether the pointer is nil and then move to dereferencing it.
…43-to-18.0-fr1 [18.0-fr1] [OSPRH-11191] Remove dereference for nil pointer
The Ensure[Horizon|Tobiko]CloudsYAML function was failing when
the CM containing the modified clouds.yaml already existed:
Object openstack/horizontest-clouds-config is already owned
by another HorizonTest controller horizontest-tests
This patch does two things:
- Ensures that we do not create the modified clouds.yaml when it
already exists.
- Removes the duplicate implementation of of the Ensure*CloudsYAML
function and replaces it with EnsureCloudsConfigMapExists.
[18.0-fr1][OSPRH-11235] Do not fail when clouds CM exists
There was a race condition in the previous implementation of the
workflows that was caused by the dependency of the workflow feature
on a ConfigMap that served as counter.
This commit simplifies the logic of the Reconcile loop in two ways:
1. Removes the dependency for an external workflow counter
2. Introduces NextAction function which decides what next action
should be performed by the Reconcile loop based on the current
state of the OpenShift cluster. The input of this function is the
instance which is currently being processed and a workflowLength.
Using these two arguments it then tells the Reconcile loop which
actions it should perform: Wait, CreateFirstJob, CreateNextJob,
EndTesting, Failure.
This approach should simplify the reconcile logic and move the
test-operator towards a unified Reconcile loop.
[18.0-fr1][OSPRH-10386] Update logic for workflows
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cmsj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cmsj: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.