Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH: Add a second source link for bills #5275

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

alexobaseki
Copy link
Contributor

Bill Status link doesn't work for current session. So I am adding the Bill Docket link.

@jessemortenson
Copy link
Contributor

If the status link does not work, should the code that adds the status link be commented out? I guess another way to put it: do you think the status link will start working again sometime this session?

FYI if there are two source URLs, there will need to be code in the NH adapter on the Plural side to select the correct one.

@jessemortenson
Copy link
Contributor

Oh - and I just remembered - NH seems to have a domain name change recently - https://gc.nh.gov/ - did you try the status link with that domain name? Might be worth checking both with it. Seems like NH is redirecting https://www.gencourt.state.nh.us to https://gc.nh.gov, so it would not surprise me if the www.gencourt.state.nh.us domain fails on certain redirects now (or in the future)

@alexobaseki
Copy link
Contributor Author

If the status link does not work, should the code that adds the status link be commented out? I guess another way to put it: do you think the status link will start working again sometime this session?

FYI if there are two source URLs, there will need to be code in the NH adapter on the Plural side to select the correct one.

I felt I should keep the existing link since the bill status URL will work at some point either when they have it fixed or when this session (2025) is archived.

Copy link
Contributor

@jessemortenson jessemortenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok LGTM

@alexobaseki
Copy link
Contributor Author

https://gc.nh.gov,

Yes. I did. I am still working on fixing the bad pdf link. I can update the url to the new one in the follow up PR too

@alexobaseki alexobaseki merged commit c2b4696 into openstates:main Feb 5, 2025
1 check passed
@alexobaseki alexobaseki deleted the nh-update-source-link branch February 5, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants