chore!(sdk): remove v1 support #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes axios and XHR support - all requests now use fetch - Removes `v1` path support for rewrap and public key - Removes `entityObject` - Removes AppIdAuthProvider - Removes `upsert`
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
This reverts commit b78cd0f.
dmihalcik-virtru
force-pushed
the
feature/axiono
branch
from
71f3b00 to
ebf24bc
Compare
|
| @@ -128,8 +128,23 @@ export default class Client { | |||
| ephemeralKeyPair?: CryptoKeyPair, | |||
| dpopEnabled = false | |||
| ) { | |||
| const enwrapAuthProvider = (a: AuthProvider): AuthProvider => { | |||
There was a problem hiding this comment.
enwrap - is this a crypto term?
There was a problem hiding this comment.
I guess I should have called it proxied or delegated/delegating. I must just have wrapping on the mind
🎁
pflynn-virtru
approved these changes
Dec 10, 2024
elizabethhealy
pushed a commit
that referenced
this pull request
Dec 13, 2024
- Removes axios and XHR support - all requests now use fetch - Removes `v1` path support for rewrap and public key - Removes `entityObject` - Removes AppIdAuthProvider - Removes `upsert` Signed-off-by: Elizabeth Healy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1path support for rewrap and public keyentityObjectupsert