Fix ciphering config verification error when AlgorithmImplementation … #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is ALGORITHM_KNOWN_BY_BOTH_ENTITIES When KiC coding is set to x4, the card profile verification fails with the following exception: Caused by: org.opentelecoms.gsm0348.api.PacketBuilderConfigurationException: KIC CipheringAlgorithmMode cannot be null for ciphered command at org.opentelecoms.gsm0348.impl.PacketBuilderImpl.verifyProfile(PacketBuilderImpl.java:136) at org.opentelecoms.gsm0348.impl.PacketBuilderImpl.setProfile(PacketBuilderImpl.java:296) at org.opentelecoms.gsm0348.impl.PacketBuilderImpl.<init>(PacketBuilderImpl.java:87) The ciphering algorithm mode should not be checked for null if an explicit ciphering algorithm is specified.
|
hello, there is a problem with KiC decoding and verification (when AlgorithmImplementation ALGORITHM_KNOWN_BY_BOTH_ENTITIES) the "mode" bits are undefined (per specification), and resulting mode is set to null (which is expected), but the card profile verification expects mode<>null. Example: KiC coding set to 0x14 - keys set 1 and ALGORITHM_KNOWN_BY_BOTH_ENTITIES causes rg.opentelecoms.gsm0348.api.PacketBuilderConfigurationException: KIC CipheringAlgorithmMode cannot be null for ciphered command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is ALGORITHM_KNOWN_BY_BOTH_ENTITIES
When KiC coding is set to x4, the card profile verification fails with the following exception:
Caused by: org.opentelecoms.gsm0348.api.PacketBuilderConfigurationException: KIC CipheringAlgorithmMode cannot be null for ciphered command
at org.opentelecoms.gsm0348.impl.PacketBuilderImpl.verifyProfile(PacketBuilderImpl.java:136)
at org.opentelecoms.gsm0348.impl.PacketBuilderImpl.setProfile(PacketBuilderImpl.java:296)
at org.opentelecoms.gsm0348.impl.PacketBuilderImpl.(PacketBuilderImpl.java:87)
The ciphering algorithm mode should not be checked for null if an explicit ciphering algorithm is specified.