Add Layout Matching#55
Draft
bkb2135 wants to merge 5 commits intoopentensor:features/penalty_rewardsfrom
Draft
Conversation
steffencruz
reviewed
Nov 1, 2023
steffencruz
reviewed
Nov 1, 2023
steffencruz
reviewed
Nov 1, 2023
Contributor
steffencruz
left a comment
steffencruz
left a comment
There was a problem hiding this comment.
Be great to have some unit tests.
Contributor
Author
Yeah I wrote some up, how should I get these to you? |
p-ferreira
reviewed
Nov 1, 2023
| ) | ||
|
|
||
| criteria = [match_words_criteria, match_length_criteria] | ||
| criteria = [match_words_criteria, match_length_criteria, match_layout_criteria] |
Contributor
There was a problem hiding this comment.
@steffencruz what's your thoughts on including the layout criteria in the 2.1.0 release? At first glance I would think that this could be challenging both to the miners and the current reward stack evaluation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds layout matching task and criteria to answer step in validation.