Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add backend linting on github actions #272

Merged
merged 13 commits into from
Jan 7, 2025

Conversation

diofeher
Copy link
Member

@diofeher diofeher commented Jan 3, 2025

Closes #93

Adding golang linting for search/pg-indexer and backend folders:

After first run:

Screenshot 2025-01-03 at 09 56 32

How it looks on the pipeline:

Screenshot 2025-01-04 at 00 58 10

Fixes:

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • My contribution is compatible with the MPL-2.0 license and I have provided a DCO sign-off on all my commits.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.

Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
@diofeher diofeher marked this pull request as ready for review January 4, 2025 03:57
@diofeher diofeher changed the title Feat/backend linting feat: add backend linting Jan 4, 2025
@diofeher diofeher changed the title feat: add backend linting feat: add backend linting on github actions Jan 4, 2025
Signed-off-by: Diogenes Fernandes <[email protected]>
Copy link
Contributor

@abstractionfactory abstractionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments here

@diofeher
Copy link
Member Author

diofeher commented Jan 4, 2025

Signed-off-by: Diogenes Fernandes <[email protected]>
@diofeher diofeher force-pushed the feat/backend-linting branch from e9ca291 to 135643a Compare January 5, 2025 12:23
@Yantrio
Copy link
Member

Yantrio commented Jan 7, 2025

Thanks for the contribution! and sorry for my unused methods :D

@Yantrio Yantrio merged commit 76b3477 into opentofu:main Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up linting
3 participants