-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docker compose setup #293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diógenes Fernandes <[email protected]>
Signed-off-by: Diógenes Fernandes <[email protected]>
Signed-off-by: Diógenes Fernandes <[email protected]>
Signed-off-by: Diógenes Fernandes <[email protected]>
Signed-off-by: Diógenes Fernandes <[email protected]>
Signed-off-by: Diógenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Gogotchuri
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, look good! Left a few nit and a question.
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Gogotchuri
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Diógenes Fernandes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292
Local environment setup was broken for registry-ui. This PR covers a few different problems:
1 - Search worker was not available on docker compose, always returning empty responses. I've added --ip=0.0.0.0 in order to make the server available.
2 - NeonDB Serverless doesn't work well with local databases using postgres protocol because it works using HTTP/Websockets. I've tried a few different approaches like neon-proxy (that uses HTTP/Websockets), but in the end I've used a "pg" Client.
3 - The search SQL was wrong and couldn't compile, so I've made a small change on its syntax to make it work.
4 -
node_compat = true
is used to have an usable "pg" package on R2 worker environment.5 - adding script to populate r2 bucket + docs
Checklist