Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in the published POM file #274

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Jan 2, 2025

The published POM file on maven central:
https://repo1.maven.org/maven2/com/tokbox/opentok-server-sdk/4.15.0/opentok-server-sdk-4.15.0.pom

Contains links like:

<url>https://github.com/opentok/opentok-server-sdk</url>
<license>
  <name>MIT License</name>
  <url>https://raw.github.com/opentok/opentok-server-sdk/main/LICENCE.txt</url>
</license>
<scm>
   <connection>scm:[email protected]/opentok/opentok-server-sdk</connection>
   <developerConnection>scm:[email protected]/opentok/opentok-server-sdk</developerConnection>
   <url>https://github.com/opentok/opentok-server-sdk</url>
</scm>

Those links are broken.

They were correct in the POM of version 4.14.0:
https://repo1.maven.org/maven2/com/tokbox/opentok-server-sdk/4.14.0/opentok-server-sdk-4.14.0.pom

The problematic change was introduced by #255

With this PR I suggest to revert the change to the problematic line.

@jmini jmini changed the title Fix githubPath Fix links in the published POM file Jan 2, 2025
@SMadani
Copy link
Contributor

SMadani commented Jan 6, 2025

Hi @jmini, thank you for reporting this and providing the fix!

@SMadani SMadani merged commit 132e9c3 into opentok:main Jan 6, 2025
3 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants