This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Fix issue 118 #166
Open
Fix issue 118 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msach22 is the project receiving PR? I've seen some old ones not merged yet, so just wondering :) |
|
@oxcarga Thanks for filing the PR - to keep a consistent code base, how do you feel about making the PR like this: This would make sure that we're waiting on the code to complete in the native layer before executing the callback. I would also confirm that these callbacks are being called from the native layer. |
* origin/issue-118: Adding completion handler for initPublisher - issue opentok#118
…Using "requireCordovaModule" to load non-cordova module "q"
* origin/master: Fix error "Failed to install 'cordova-plugin-opentok': CordovaError: Using "requireCordovaModule" to load non-cordova module "q"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a completion handler for OT.initPublisher method
Contributing checklist
Solves issue(s)
#118
Hope this makes sense; We needed this callback to know exactly the moment initPublisher returns so we can publish to session right after that.