Link with larger radius if we don't find results for all of the requested modes#7384
Open
optionsome wants to merge 3 commits intoopentripplanner:dev-2.xfrom
Open
Link with larger radius if we don't find results for all of the requested modes#7384optionsome wants to merge 3 commits intoopentripplanner:dev-2.xfrom
optionsome wants to merge 3 commits intoopentripplanner:dev-2.xfrom
Conversation
optionsome
added
the
!Bug
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7384 +/- ##
=============================================
- Coverage 70.96% 70.91% -0.05%
- Complexity 20806 20834 +28
=============================================
Files 2327 2328 +1
Lines 86539 86647 +108
Branches 8572 8595 +23
=============================================
+ Hits 61409 61450 +41
- Misses 22165 22225 +60
- Partials 2965 2972 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
habrahamsson-skanetrafiken
requested review from
leonardehrenfried and
vesameskanen
optionsome
force-pushed
the
fix-multimode-linking-expansion
branch
from
eb051ce to
4bd26e7
Compare
| * for request scoped linking when the first attempt didn't find | ||
| * link for all the requested modes. | ||
| */ | ||
| public DisposableEdgeCollection linkVertexForRequest( |
Member
There was a problem hiding this comment.
Can it be package-private?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linking with larger radius is done if we don't find results for all of the requested modes. Previously we only did it when we didn't find any results (which was a regression).
This is built on top of #7383
Issue
No issue, this is related to problems with existing multi-mode linking support that we started to use in #6972
Unit tests
Added and updated
Documentation
Added some more javadoc
Changelog
From title