Introduced tf-keras for compatibility with tensorflow>2.15 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iskandr This seems to be failing due to coveralls - any idea what's going on there? 
|
If I had to guess, maybe it is because my PR has came from a fork of mhcflurry? |
|
Thanks for this contribution @jday1 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with the release documentation for tensorflow 2.16.1, I have updated the code to use
tf-keraseverywhere it is required. This is becausetensorflow==2.16.1onwards uses keras 3 rather than keras 2 by default. As a result, all models using keras 2 require tf-keras for loading.As a result of introducing
tf-keras, I have increased the minimum version of tensorflow to2.15.0. This is because the first version oftf-keraswhich has a tensorflow dependency compatibility restrictions (2.15.1) hastensorflow>=2.15.I have checked all tests pass locally and the the examples from the README run.