Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin numpy version < 2.0 #246

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Pin numpy version < 2.0 #246

merged 2 commits into from
Nov 8, 2024

Conversation

ndalchau
Copy link
Contributor

@ndalchau ndalchau commented Nov 7, 2024

Closes #245

@timodonnell timodonnell mentioned this pull request Nov 8, 2024
Closed
@ndalchau
Copy link
Contributor Author

ndalchau commented Nov 8, 2024

I'm surprised there is a failure for 3.10 when 3.9 and 3.11 work. Is this a flaky test perhaps?

@timodonnell
Copy link
Contributor

timodonnell commented Nov 8, 2024 via email

@ndalchau
Copy link
Contributor Author

ndalchau commented Nov 8, 2024

Looks like another case of the stochastic test! This time python 3.9 failed.

@timodonnell
Copy link
Contributor

Yeah, I'm going to merge this and we can sort out the stochastic test failures separately #248

@timodonnell timodonnell merged commit e2b5d8d into openvax:master Nov 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

numpy v2 not supported
2 participants
@ndalchau @timodonnell