Skip to content

Text2Video sample fix #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgonorov wants to merge 1 commit into from
+6 −6
Open

Text2Video sample fix #3243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions samples/python/video_generation/text2video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ def save_video(filename: str, video_tensor, fps: int = 25):
writer = cv2.VideoWriter(output_path, fourcc, fps, (width, height))

for f in range(num_frames):
writer.write(video_data[b, f])
frame_bgr = cv2.cvtColor(video_data[b, f], cv2.COLOR_RGB2BGR)
writer.write(frame_bgr)

writer.release()
print(f"Wrote {output_path} ({num_frames} frames, {width}x{height} @ {fps} fps)")
Expand Down Expand Up @@ -58,11 +59,10 @@ def callback(step, num_steps, latent):
save_video("genai_video.avi", output.video, frame_rate)

print(f"\nPerformance metrics:")
print(f" Load time: {output.perf_metrics.load_time:.2f} ms")
print(f" Generate duration: {output.perf_metrics.get_generate_duration().mean:.2f} ms")
print(f" Text encoder duration: {output.perf_metrics.get_text_encoder_duration().mean:.2f} ms")
print(f" Denoising duration: {output.perf_metrics.get_denoising_duration().mean:.2f} ms")
print(f" Decoding duration: {output.perf_metrics.get_decoding_duration().mean:.2f} ms")
print(f" Load time: {output.perf_metrics.get_load_time():.2f} ms")
print(f" Generate duration: {output.perf_metrics.get_generate_duration():.2f} ms")
print(f" Transformer duration: {output.perf_metrics.get_transformer_infer_duration().mean:.2f} ms")
print(f" VAE decoder duration: {output.perf_metrics.get_vae_decoder_infer_duration():.2f} ms")
Comment on lines +62 to +65
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent API usage: get_transformer_infer_duration() returns an object with a .mean attribute while other metrics (get_load_time() and get_generate_duration()) return scalar values directly. Consider using .mean consistently if all methods return objects with mean values, or remove .mean if this method also returns a scalar.

Suggested change
print(f" Load time: {output.perf_metrics.get_load_time():.2f} ms")
print(f" Generate duration: {output.perf_metrics.get_generate_duration():.2f} ms")
print(f" Transformer duration: {output.perf_metrics.get_transformer_infer_duration().mean:.2f} ms")
print(f" VAE decoder duration: {output.perf_metrics.get_vae_decoder_infer_duration():.2f} ms")
print(f" Load time: {output.perf_metrics.get_load_time().mean:.2f} ms")
print(f" Generate duration: {output.perf_metrics.get_generate_duration().mean:.2f} ms")
print(f" Transformer duration: {output.perf_metrics.get_transformer_infer_duration().mean:.2f} ms")
print(f" VAE decoder duration: {output.perf_metrics.get_vae_decoder_infer_duration().mean:.2f} ms")

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method name inconsistency should be verified: line 64 uses get_transformer_infer_duration().mean (with .mean attribute access) while this line uses get_vae_decoder_infer_duration() directly (without .mean). Ensure both methods have the same return type for consistency.

Suggested change
print(f" VAE decoder duration: {output.perf_metrics.get_vae_decoder_infer_duration():.2f} ms")
print(f" VAE decoder duration: {output.perf_metrics.get_vae_decoder_infer_duration().mean:.2f} ms")

Copilot uses AI. Check for mistakes.


if __name__ == "__main__":
Expand Down
Loading