Notebooks selector app with manual GitHub Pages deploy #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatarkan
added
enhancement
yatarkan
requested review from
as-suvorov,
a team,
apaniukov,
itrushkin and
aleksandr-mokrov
and removed request for
a team
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
aleksandr-mokrov
approved these changes
Feb 6, 2024
as-suvorov
approved these changes
Feb 8, 2024
|
|
||
| useEffect(() => { | ||
| setPage(1); | ||
| }, [selectedTags, searchValue, sort, setPage]); |
There was a problem hiding this comment.
why setPage in dependencies?
There was a problem hiding this comment.
setPage function is used inside this effect so it is considered as a dependency as well
There was a problem hiding this comment.
Should notebooksService.getNotebooks from the next effect be in dependencies as well?
| @@ -1,9 +1,9 @@ | |||
| // @ts-check | |||
|
|
|||
There was a problem hiding this comment.
Consider using json schema instead of manual validation
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CVS-119857
This PR introduces OpenVINO Notebooks selector app written with
TypeScript,Reactandvite. Moreover, new GitHub Actions workflow is added for manual app deploy to repository GitHub Pages (through workflow dispatch via GitHub Actions UI).Note for reviewers: Files in
./selector/src/@spark-designdirectory can be skipped during review - these files are from Spark Design open-source package and can be treated as a dependency.