Skip to content

Update to genai usage #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aleksandr-mokrov
Copy link
Contributor

CVS-161647

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aleksandr-mokrov aleksandr-mokrov marked this pull request as ready for review February 4, 2025 22:23
Copy link

review-notebook-app bot commented Feb 5, 2025

View / edit / reply to this conversation on ReviewNB

eaidova commented on 2025-02-05T04:49:15Z
----------------------------------------------------------------

Please add info about genai usage also in general notebook description too.

image tokens is not correct wording, probably you mean tensor/array (tokens associated with tokenization process that encode string to numeric representation, reverse process is detokenization, back from indices to string).

IMHO, "just run" is your value judgement - it is better to avoid such constructions and give people make own decision (for you it maybe something simple, but somebody may have different opinion) that highlight simplicity of actions, but if it is simple, why you need highlight that? :)

I think this text can be simplified:

Pipeline generate method returns numpy array with generated content. You can convert it to PIL.Image using Image.fromarray


Copy link

review-notebook-app bot commented Feb 5, 2025

View / edit / reply to this conversation on ReviewNB

eaidova commented on 2025-02-05T04:49:15Z
----------------------------------------------------------------

Line #2.        !optimum-cli export openvino -m stabilityai/stable-diffusion-xl-base-1.0 --weight-format int8 {model_dir}

can you please also move it to use optimum_cli helper?


Copy link

review-notebook-app bot commented Feb 5, 2025

View / edit / reply to this conversation on ReviewNB

eaidova commented on 2025-02-05T04:53:43Z
----------------------------------------------------------------

Line #3.    num_steps = 30

generated images looks worse than previous. I believe it may be connected with too large number of steps for generation.

Model that you use now is lcm, it usually requires 4 steps only to get results.


@aleksandr-mokrov
Copy link
Contributor Author

tiny-sd needs to be excluded for awhile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant