Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add genai to sdxl-turbo #2719

Merged

Conversation

aleksandr-mokrov
Copy link
Contributor

CVS-161647

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aleksandr-mokrov aleksandr-mokrov changed the title Add genai Add genai to sdxl-turbo Feb 5, 2025
Copy link

review-notebook-app bot commented Feb 6, 2025

View / edit / reply to this conversation on ReviewNB

eaidova commented on 2025-02-06T04:28:59Z
----------------------------------------------------------------

Line #29.        optimum_cli(sdxl_model_id, model_dir, additional_args={"weight-format": "fp16", "task": "stable-diffusion-xl"})

task is not obligated and if you specify it, it is better to use more generic name text-to-image


Copy link

review-notebook-app bot commented Feb 6, 2025

View / edit / reply to this conversation on ReviewNB

eaidova commented on 2025-02-06T04:29:00Z
----------------------------------------------------------------

Line #11.        optimum_cli(sdxl_model_id, model_dir_int8, additional_args={"weight-format": "fp16", "task": "stable-diffusion-xl"})

not sure that you need convert model twice, when you can just copy content.

I think we can move this utility to notebook_utils.py and reuse it for such cases

def copy_model_files(src_dir, dst_dir, ignore_llm=True, ignore_vision_encoder=True):


@eaidova eaidova merged commit f0deb2a into openvinotoolkit:latest Feb 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants