Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remote logs #1063

Merged
merged 17 commits into from
Jan 11, 2024
Merged

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Jan 10, 2024

Summary of Changes

Add a new package that allows replacing the Aries Framework Javascript (AFJ) consoler logger with a class that supports both console and remote logging to a Loki stack.

To get a full understanding of this contribution see the README.md noted as one of the files added to this PR.

Related Issues

n/a

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

jleach added 2 commits January 9, 2024 17:06
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach self-assigned this Jan 10, 2024
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a208a45) 61.54% compared to head (64705c3) 61.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   61.54%   61.54%           
=======================================
  Files         170      170           
  Lines        5458     5458           
  Branches     1572     1572           
=======================================
  Hits         3359     3359           
  Misses       2075     2075           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach marked this pull request as ready for review January 10, 2024 23:58
@jleach jleach requested a review from a team as a code owner January 10, 2024 23:58
bryce-mcmath
bryce-mcmath previously approved these changes Jan 11, 2024
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
bryce-mcmath
bryce-mcmath previously approved these changes Jan 11, 2024
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach merged commit e677e16 into openwallet-foundation:main Jan 11, 2024
7 checks passed
@jleach jleach deleted the feat/remote-logs branch July 30, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants