feat: upgrade to RN 0.73.5 #1439

MosCD3 · 2025-02-12T14:16:10Z

Summary of Changes

iOS part done so far
All changes re-reviewed and re-done by @MaSMas0

New version supports experimental and chrome debugger (RN Debugger)
Added menu to start chrome debugger

Replace this text with a high-level summary of the changes included in this PR.

Screenshots, videos, or gifs

Replace this text with embedded media for UI changes if they are included in this PR. If there are none, simply enter N/A

Breaking change guide

Replace this text with any breaking changes included in this PR along with how to address them in downstream projects. If there are none, simply enter N/A

Related Issues

Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
If applicable, screenshots, gifs, or video are included for UI changes
If applicable, breaking changes are described above along with how to address them
Updated documentation as needed for changed code and new or modified features
Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

Signed-off-by: Mostafa Gamal <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

…penwallet-foundation#1433) Signed-off-by: fc-santos <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

…ndation#1427) Signed-off-by: fc-santos <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

…tion#1438) Signed-off-by: ClaudeArs <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

Signed-off-by: Mostafa Gamal <[email protected]> Signed-off-by: Mostafa Gamal <[email protected]> Co-authored-by: Bryce McMath <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

Signed-off-by: Bryce McMath <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

codecov-commenter · 2025-02-17T23:41:17Z

Codecov Report

Attention: Patch coverage is 15.51724% with 49 lines in your changes missing coverage. Please review.

Project coverage is 55.19%. Comparing base (aff8281) to head (2c420df).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/legacy/core/App/contexts/auth.tsx	4.16%	46 Missing ⚠️
packages/legacy/core/App/DebugCode.ts	62.50%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
- Coverage   55.52%   55.19%   -0.34%     
==========================================
  Files         223      228       +5     
  Lines        7985     8195     +210     
  Branches     2241     2329      +88     
==========================================
+ Hits         4434     4523      +89     
- Misses       3528     3649     +121     
  Partials       23       23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mostafa Gamal <[email protected]>

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

bryce-mcmath · 2025-02-20T17:28:23Z

@MosCD3 could we possibly chat about this PR at the Bifold call next week?

bryce-mcmath

Few things, but awesome work

bryce-mcmath · 2025-02-20T17:42:43Z

.github/workflows/main.yaml

+          bundle install && \
+          cd ios && \
+          rm -rf Pods && \
+          rm -f Podfile.lock && \
+          pod install && \
+          cd .. && \


Erasing the lockfile on the main GHA defeats the purpose of a lockfile. This change would stop our build from being deterministic . Can we make use of the same command (ios:setup) we would use locally? It's alright if we have to update that command a bit as part of this PR but we should still use it.

packages/legacy/app/Gemfile

bryce-mcmath · 2025-02-20T18:30:21Z

packages/legacy/core/App/contexts/auth.tsx

+if (!__DEV__) {
+  import('@hyperledger/aries-askar-react-native')
+    .then(() => {
+      // console.log('Askar native module loaded successfully')
+    })
+    .catch(() => {
+      // console.error('Failed to load Askar native module:', error)
+    })
+} else {
+  // console.log('Askar native module not loaded in debug mode')
+}
+
+//NOTE: This line is throwing an error in debugging due to native modules is it still needed? maybe the above is a workaround
+// to be able to use RNDebugger in debug mode
 // eslint-disable-next-line import/no-extraneous-dependencies
 import 'reflect-metadata'

-import { AskarWallet } from '@credo-ts/askar'
+import { AskarWallet } from '@credo-ts/askar' // is this enough instead of line number 2


I don't think we should conditionally import. Is the NOTE for the conditional import above or the reflect-metadata line below?

I don't think reflect-metadata is still needed but we can just test out the app after removing it to find out if that's true. We should remove it from the entire project if possible

@hyperledger/aries-askar-react-native
is that needed Bryce, we already importing AzkarWallet from credo
This import is causing issues with real native chrome debugger, if its not needed anymore its better to remove the whole statement

Probably fine, we should just check that without that import we are still able to accept credentials and view / delete them after an app restart

bryce-mcmath · 2025-02-21T00:45:31Z

packages/legacy/core/__tests__/components/__snapshots__/VerifierCredentialCard.test.tsx.snap

@@ -203,7 +203,7 @@ exports[`VerifierCredentialCard Component Renders correctly 1`] = `
          removeClippedSubviews={false}
          renderItem={[Function]}
          scrollEnabled={false}
-          scrollEventThrottle={50}
+          scrollEventThrottle={0.0001}


What caused this change?

this was part of the snapshot update

Co-authored-by: Bryce McMath <[email protected]> Signed-off-by: Mostafa Gamal <[email protected]>

sonarqubecloud · 2025-02-21T20:16:18Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

timbl-ont · 2025-02-21T22:09:52Z

Authentication with a PIN is broken - react-native-keychain needs to be updated to at least 8.1.2 for RN 7.3 support. There is an Android bug fixed in 8.1.3 that allowed Biometric authentication to be bypassed if someone had recently authenticated.

There are also some security enhancements in later releases that should be considered for a future PR.

https://github.com/oblador/react-native-keychain/releases

jleach changed the title ~~Upgrade to RN 0.73.5~~ feat: upgrade to RN 0.73.5 Feb 12, 2025

MosCD3 marked this pull request as ready for review February 13, 2025 03:55

MosCD3 requested a review from a team as a code owner February 13, 2025 03:55

MosCD3 marked this pull request as draft February 13, 2025 04:11

MaSMas0 force-pushed the refactor/moscd3/upgrade-rn-73-5 branch from bac8e18 to bb4e828 Compare February 17, 2025 20:45

MosCD3 marked this pull request as ready for review February 17, 2025 20:47

MosCD3 and others added 12 commits February 17, 2025 22:05

Upgrade to RN 0.73.5

1a2350c

Signed-off-by: Mostafa Gamal <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

upgrade ios and change the AppDelegate file to be support c++

866a6b0

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

upgrade android to v73.5

02e6d18

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

add solution for RNDebugger and also for expermintal debugger

c28c8ec

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

feat: make attemptLockout rules injectable in the Config interface (o…

42aeb1e

…penwallet-foundation#1433) Signed-off-by: fc-santos <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

feat: add new OCA branding 1.1 for credential details (openwallet-fou…

7050e8b

…ndation#1427) Signed-off-by: fc-santos <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

feat: disable element below modalTour for TalkBack (openwallet-founda…

cf63cfe

…tion#1438) Signed-off-by: ClaudeArs <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

feat: OpenID4VP common OCA UI (openwallet-foundation#1392)

f7fb4c9

Signed-off-by: Mostafa Gamal <[email protected]> Signed-off-by: Mostafa Gamal <[email protected]> Co-authored-by: Bryce McMath <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

feat: add scan overlay, refactor (openwallet-foundation#1440)

88bc048

Signed-off-by: Bryce McMath <[email protected]> Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

adding comment for flipper

59ed7f9

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

Update Gemfile.lock to match Gemfile

e22784e

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

fix the ios build action after the upgrade

67219c4

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

MaSMas0 force-pushed the refactor/moscd3/upgrade-rn-73-5 branch from 8b9707e to 67219c4 Compare February 17, 2025 21:06

MaSMas0 and others added 3 commits February 17, 2025 22:19

Update Podfile.lock to resolve hermes-engine version mismatch

cb2d18d

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

fix for main.yaml android build & ios build

2b0cc3d

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

Merge branch 'main' into refactor/moscd3/upgrade-rn-73-5

c77713e

MaSMas0 force-pushed the refactor/moscd3/upgrade-rn-73-5 branch 3 times, most recently from cb500bb to 634439e Compare February 17, 2025 22:54

remove pod update hermes to try the ios build

2c420df

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

MaSMas0 force-pushed the refactor/moscd3/upgrade-rn-73-5 branch from 634439e to 2c420df Compare February 17, 2025 23:25

jleach marked this pull request as draft February 18, 2025 17:16

Update snapshots

baa0369

Signed-off-by: Mostafa Gamal <[email protected]>

MosCD3 marked this pull request as ready for review February 18, 2025 20:30

MosCD3 marked this pull request as draft February 18, 2025 20:35

MosCD3 and others added 4 commits February 18, 2025 15:37

revert a test

511333c

Signed-off-by: Mostafa Gamal <[email protected]>

Merge branch 'main' into refactor/moscd3/upgrade-rn-73-5

04226db

increment the minimumios deploymentfrom 11.0 to 12.0

5945cff

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

updating snapshots to pass the failing tests

9c5813b

Signed-off-by: Mohamed Abd El-Samie Ahmad Mansour <[email protected]>

MaSMas0 force-pushed the refactor/moscd3/upgrade-rn-73-5 branch from 07dcb79 to 9c5813b Compare February 18, 2025 22:01

MosCD3 marked this pull request as ready for review February 18, 2025 22:34

bryce-mcmath added the do not merge Don't merge when label present label Feb 20, 2025

bryce-mcmath requested changes Feb 21, 2025

View reviewed changes

Update packages/legacy/app/Gemfile

eae6388

Co-authored-by: Bryce McMath <[email protected]> Signed-off-by: Mostafa Gamal <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade to RN 0.73.5 #1439

feat: upgrade to RN 0.73.5 #1439

MosCD3 commented Feb 12, 2025 •

edited

Loading

codecov-commenter commented Feb 17, 2025

bryce-mcmath commented Feb 20, 2025

bryce-mcmath left a comment

bryce-mcmath Feb 20, 2025

bryce-mcmath Feb 20, 2025

MosCD3 Feb 21, 2025

bryce-mcmath Feb 21, 2025

bryce-mcmath Feb 21, 2025

MosCD3 Feb 21, 2025

sonarqubecloud bot commented Feb 21, 2025

timbl-ont commented Feb 21, 2025

feat: upgrade to RN 0.73.5 #1439

Are you sure you want to change the base?

feat: upgrade to RN 0.73.5 #1439

Conversation

MosCD3 commented Feb 12, 2025 • edited Loading

Summary of Changes

Screenshots, videos, or gifs

Breaking change guide

Related Issues

Pull Request Checklist

codecov-commenter commented Feb 17, 2025

Codecov Report

bryce-mcmath commented Feb 20, 2025

bryce-mcmath left a comment

Choose a reason for hiding this comment

bryce-mcmath Feb 20, 2025

Choose a reason for hiding this comment

bryce-mcmath Feb 20, 2025

Choose a reason for hiding this comment

MosCD3 Feb 21, 2025

Choose a reason for hiding this comment

bryce-mcmath Feb 21, 2025

Choose a reason for hiding this comment

bryce-mcmath Feb 21, 2025

Choose a reason for hiding this comment

MosCD3 Feb 21, 2025

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 21, 2025

Quality Gate passed

timbl-ont commented Feb 21, 2025

MosCD3 commented Feb 12, 2025 •

edited

Loading