fix: message @type in problem report (#2151)

Signed-off-by: Timo Glastra <[email protected]>
openwallet-foundation · Jan 23, 2025 · 3984044 · 3984044
1 parent 2d10ec3
commit 3984044
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/core/src/agent/MessageReceiver.ts b/packages/core/src/agent/MessageReceiver.ts
@@ -258,11 +258,11 @@ export class MessageReceiver {
     try {
       messageTransformed = JsonTransformer.fromJSON(message, MessageClass)
     } catch (error) {
-      this.logger.error(`Error validating message ${message.type}`, {
+      this.logger.error(`Error validating message ${message['@type']}`, {
         errors: error,
         message: JSON.stringify(message),
       })
-      throw new ProblemReportError(`Error validating message ${message.type}`, {
+      throw new ProblemReportError(`Error validating message ${message['@type']}`, {
         problemCode: ProblemReportReason.MessageParseFailure,
       })
     }

diff --git a/packages/openid4vc/src/openid4vc-holder/__tests__/openid4vci-holder.test.ts b/packages/openid4vc/src/openid4vc-holder/__tests__/openid4vci-holder.test.ts
@@ -8,6 +8,7 @@ import {
   KeyType,
   TypedArrayEncoder,
   W3cJwtVerifiableCredential,
+  W3cCredentialService,
 } from '@credo-ts/core'
 import nock, { cleanAll, enableNetConnect } from 'nock'
 
@@ -100,6 +101,13 @@ describe('OpenId4VcHolder', () => {
       const accessTokenResponse = await holder.modules.openId4VcHolder.requestToken({
         resolvedCredentialOffer: resolved,
       })
+
+      // The credential issued by mattr launchpad is expired, so we mock the verification...
+      const w3cCredentialService = holder.dependencyManager.resolve(W3cCredentialService)
+      jest
+        .spyOn(w3cCredentialService, 'verifyCredential')
+        .mockImplementationOnce(async () => ({ isValid: true, validations: {} }))
+
       const credentialsResult = await holder.modules.openId4VcHolder.requestCredentials({
         resolvedCredentialOffer: resolved,
         ...accessTokenResponse,