feat: default to uncompressed keys #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d7df917 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
berendsliedrecht
force-pushed
the
key-compression
branch
2 times, most recently
from
3a5b77f to
7075bbc
Compare
TimoGlastra
approved these changes
Feb 4, 2025
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
key-compression
branch
from
267c22c to
4758e8b
Compare
…ative implementations - By default rely on uncompressed keys instead of compressed (for P256, P384, P521 and K256) - Utilze Uint8Array more instead of Buffer (i.e. for internally representing a key) Signed-off-by: Berend Sliedrecht <[email protected]>
TimoGlastra
reviewed
Feb 6, 2025
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
key-compression
branch
4 times, most recently
from
7652bf8 to
0451302
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
key-compression
branch
from
0451302 to
1df37b3
Compare
…key bytes representation - Remove dependency on external Big Number libraries - Default to use of uncompressed keys for Secp256k1, Secp256r1, Secp384r1 and Secp521r1 Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
merged commit 297d209
into
openwallet-foundation:main
16 checks passed
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Feb 19, 2025
* feat: support A128CBC-HS256 encryption algorithm for JWE (openwallet-foundation#2174) Signed-off-by: Timo Glastra <[email protected]> * fix(cheqd): cheqd revocationRegistryDefinition resource name (openwallet-foundation#2139) Signed-off-by: DaevMithran <[email protected]> * refactor: split async `getData` method on x509 certificate (openwallet-foundation#2180) * feat: default to uncompressed keys (openwallet-foundation#2165) Signed-off-by: Berend Sliedrecht <[email protected]> * chore: update @hyperledger/aries-askar to @openwallet-foundation/askar (openwallet-foundation#2188) Signed-off-by: Berend Sliedrecht <[email protected]> * fix: typo statefull -> stateful (openwallet-foundation#2189) Signed-off-by: Timo Glastra <[email protected]> * chore: update ec-compression (openwallet-foundation#2190) Signed-off-by: Berend Sliedrecht <[email protected]> * chore(mdoc): update dependency (openwallet-foundation#2191) Signed-off-by: Berend Sliedrecht <[email protected]> Co-authored-by: Timo Glastra <[email protected]> * chore(mdoc): export DateOnly from @animo-id/mdoc (openwallet-foundation#2192) Signed-off-by: Berend Sliedrecht <[email protected]> * fix(askar): use compressed key as identifier (openwallet-foundation#2193) Signed-off-by: Timo Glastra <[email protected]> * add local packed files Signed-off-by: Timo Glastra <[email protected]> * feat: enable dcql selection Signed-off-by: Timo Glastra <[email protected]> * fix typing dcql selection Signed-off-by: Timo Glastra <[email protected]> * dc api session transcript options Signed-off-by: Timo Glastra <[email protected]> * fix: import Signed-off-by: Timo Glastra <[email protected]> * add binaries Signed-off-by: Timo Glastra <[email protected]> * remove binaries Signed-off-by: Timo Glastra <[email protected]> --------- Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: DaevMithran <[email protected]> Signed-off-by: Berend Sliedrecht <[email protected]> Co-authored-by: DaevMithran <[email protected]> Co-authored-by: Berend Sliedrecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO for future crypto changes: