feat(x509): Update certificate creation API #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <[email protected]>
… via the `agent.x509.createCertificate` API where the `subjectPublicKey` is not supplied or equal to the `authorityKey` - allow to create more complex X.509 certificates Signed-off-by: Berend Sliedrecht <[email protected]>
🦋 Changeset detectedLatest commit: ba08279 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
berendsliedrecht
force-pushed
the
update-x509-interface
branch
from
aeb6ea5 to
79dff4e
Compare
TimoGlastra
approved these changes
Feb 18, 2025
| @@ -228,6 +311,11 @@ export class X509Certificate { | |||
| return certificate.subject | |||
| } | |||
|
|
|||
| public get issuer() { | |||
| const certificate = new x509.X509Certificate(this.rawCertificate) | |||
There was a problem hiding this comment.
Should we store an instance of the x509 lib cert in this class? I'm not sure on the overhead of parsing
… via the `agent.x509.createCertificate` API where the `subjectPublicKey` is not supplied or equal to the `authorityKey` - allow to create more complex X.509 certificates Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
update-x509-interface
branch
from
79dff4e to
ba08279
Compare
berendsliedrecht
merged commit dca4fdf
into
openwallet-foundation:main
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the X.509 certificate creation api to not only create self-signed certs anymore.