Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: organize as monorepo project structure #46

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Feb 14, 2025

Reorganize the project structure to follow a conventional monorepo structure.

Fixes #43

@jleach
Copy link
Contributor Author

jleach commented Feb 14, 2025

@TimoGlastra @genaris Not ready for review. Just a FYI this exists and is a WIP.

Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach marked this pull request as ready for review February 19, 2025 21:54
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Copy link

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @jleach ! Looking forward to have it merged so we can add our message pickup packages.

I have a question regarding the pnpm lock file. Otherwise it LGTM!

@@ -0,0 +1,35 @@
FROM node:20 AS base
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since node 20 is under maintenance now, do you think we can upgrade to node:22? I'm not aware of any particular issue with it (or at least no more than the ones we had with 20 😅 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this pnpm lock file generated? I mean, if I go to the root of the project and execute pnpm install, it will generate/update root's pnpm-lock.yaml, but it won't touch anything under apps/*.

Is this a manual copy of the one at the root? If so, could this copy be done using a script and gitignoring it in order to reduce the possibility of mismatching copies?

Copy link
Contributor Author

@jleach jleach Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not meant to be there. Works like yarn in that it should only live at the root. I must have copied it while trying to figure out how to do Docker builds with workspaces, one lock file, and pnpm's linking.

Fixed.

Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach requested a review from genaris February 20, 2025 23:16
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to monorepo structure
2 participants