-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes #12
Small fixes #12
Conversation
3e7f119
to
b59d559
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 232 239 +7
Branches 63 64 +1
=========================================
+ Hits 232 239 +7 ☔ View full report in Codecov by Sentry. |
291ca31
to
e1997e9
Compare
…one of openzim/hatch-openzim
587fd93
to
7dc426e
Compare
7dc426e
to
f61f00a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ; I see #13 was fixed by adding a sample git config. I assume that's because we want to test retrieving from a gitconfig but do support no gitconfig. Deserves a comment IMO
86e043e
to
a9f255d
Compare
Good point, thank you.
|
Fix #10
Fix #11
Fix #13
Also upgrades to Python bootstrap 1.0 and activate strict types checks (should have been from the beginning) and corresponding type fixes.
Also includes small README enhancement (styling for readability)