Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit handling of images processing and other fixes #2143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Revisit handling of images processing and other fixes

88bbeec
Select commit
Loading
Failed to load commit list.
Open

Revisit handling of images processing and other fixes #2143

Revisit handling of images processing and other fixes
88bbeec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2025 in 1s

75.19% (-0.79%) compared to 75cf0fe

View this Pull Request on Codecov

75.19% (-0.79%) compared to 75cf0fe

Details

Codecov Report

Attention: Patch coverage is 75.55556% with 33 lines in your changes missing coverage. Please review.

Project coverage is 75.19%. Comparing base (75cf0fe) to head (88bbeec).

Files with missing lines Patch % Lines
src/Downloader.ts 53.06% 19 Missing and 4 partials ⚠️
src/mwoffliner.lib.ts 60.00% 2 Missing ⚠️
src/renderers/abstract.renderer.ts 94.73% 2 Missing ⚠️
src/util/misc.ts 0.00% 2 Missing ⚠️
src/MediaWiki.ts 66.66% 1 Missing ⚠️
src/S3.ts 0.00% 1 Missing ⚠️
src/util/articleListMainPage.ts 0.00% 1 Missing ⚠️
src/util/saveArticles.ts 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
- Coverage   75.98%   75.19%   -0.79%     
==========================================
  Files          41       41              
  Lines        3202     3213      +11     
  Branches      706      704       -2     
==========================================
- Hits         2433     2416      -17     
- Misses        655      676      +21     
- Partials      114      121       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.