Fix disable_metadata_checks behavior and fix StaticItem support of bytes content #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
StringProvider
supports bothbytes
andstr
types ascontent
butStaticItem
accepted onlystr
in its type hintadd_item_for
to use newStaticItem
parametersmain
code on kolibri showed an issue when the content passed toadd_item_for
/StaticItem
is an empty string "" ; content is not set andStaticItem
fails to know which content provider has to be usedChanges
bytes
andstr
types ascontent
inStaticItem
bytes
andstr
types ascontent
in scraperlibStringProvider
StringProvider
disable_metadata_checks