Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing direct dependencies #233

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add missing direct dependencies #233

merged 1 commit into from
Jan 6, 2025

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Dec 20, 2024

Fix #226

I did not found more direct dependencies than what was listed in the issue.

Remarks:

  • for pillow, I confirmed 7.0.0 is ok (tests are green) but last 6.x is not
  • for urllib3, 1.26.5 is a minimum for tests to test ; they introduce breaking changes in minor so I restricted to < 2.3 ... to be updated regularly obviously
  • for pixexif, I pinned a version like optimize-image did, this is a nightmare otherwise
  • for idna, the range is relatively wide open, even if recent versions mention official support of Python 3.12 ... since tests are OK, I feel like it is ok to use an old version if someone needs it

I checked other deps and no update (widening of upper bound) is needed since no newer version exist

@benoit74 benoit74 self-assigned this Dec 20, 2024
@benoit74 benoit74 marked this pull request as ready for review December 20, 2024 09:58
@benoit74 benoit74 requested a review from rgaudin December 20, 2024 09:58
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5f71a29) to head (9a32a85).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #233   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         2455      2455           
  Branches       331       331           
=========================================
  Hits          2455      2455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 merged commit 562c997 into main Jan 6, 2025
7 checks passed
@benoit74 benoit74 deleted the direct_deps branch January 6, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing direct dependencies
2 participants