Skip to content

Meta: Helm Integration follow ups #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
11 tasks done
varshaprasad96 opened this issue May 31, 2024 · 3 comments
Closed
11 tasks done

Meta: Helm Integration follow ups #903

varshaprasad96 opened this issue May 31, 2024 · 3 comments
Assignees
Labels
epic v1.x Issues related to OLMv1 features that come after 1.0

Comments

@varshaprasad96
Copy link
Member

varshaprasad96 commented May 31, 2024

This issue tracks the follow ups which are in queue after the helm integration feature is merged to main: #846

Codebase:

Tests:

Moved to #733

@joelanford
Copy link
Member

joelanford commented Jun 14, 2024

Another thing I just found. We setup finalizers in main.go, but then don't actually set them on the reconciler or call Finalize during reconciliation. I tried updating to do these things, but then the controller started panic-ing because the finalizer expects to finalize a BundleDeployment, but we are now trying to finalize a ClusterExtension.

I added an item to the checklist in the description (#942)

@tmshort
Copy link
Contributor

tmshort commented Jun 27, 2024

@joelanford should this be considered an epic, in place of or addition to #733?

@tmshort tmshort added epic v1.0 Issues related to the initial stable release of OLMv1 labels Jun 27, 2024
@tmshort tmshort self-assigned this Jun 27, 2024
@tmshort tmshort moved this to Implementing in OLM v1 Jun 27, 2024
@tmshort tmshort added v1.x Issues related to OLMv1 features that come after 1.0 and removed v1.0 Issues related to the initial stable release of OLMv1 labels Jun 27, 2024
@tmshort
Copy link
Contributor

tmshort commented Aug 27, 2024

All tasks are done.

@tmshort tmshort closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic v1.x Issues related to OLMv1 features that come after 1.0
Projects
Archived in project
Development

No branches or pull requests

3 participants