Skip to content

Fix: finalizers not set on ClusterExtension #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joelanford opened this issue Jun 14, 2024 · 1 comment
Closed

Fix: finalizers not set on ClusterExtension #942

joelanford opened this issue Jun 14, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1

Comments

@joelanford
Copy link
Member

joelanford commented Jun 14, 2024 •
edited
Loading

Another thing I just found. We setup finalizers in main.go, but then don't actually set them on the reconciler or call Finalize during reconciliation. I tried updating to do these things, but then the controller started panic-ing because the finalizer expects to finalize a BundleDeployment, but we are now trying to finalize a ClusterExtension.

Originally posted by @joelanford in #903 (comment)
@joelanford joelanford mentioned this issue Jun 14, 2024
Closed
11 tasks
@joelanford joelanford added kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1 labels Jun 15, 2024
@joelanford
Copy link
Member Author

This was fixed by #941

@joelanford joelanford moved this to Done in OLM v1 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1
Projects
OLM v1
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joelanford