Skip to content

🌱 Add timer to certpoolwatcher #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Apr 15, 2025

Adds a 10 minute timer to refresh the certpool

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner April 15, 2025 15:22
@openshift-ci openshift-ci bot requested review from dtfranz and oceanc80 April 15, 2025 15:23
Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 72f7592
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67ffdf89bc916b0008c90be5
😎 Deploy Preview https://deploy-preview-1920--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.02%. Comparing base (543f099) to head (72f7592).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/shared/util/http/certpoolwatcher.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
- Coverage   66.06%   66.02%   -0.04%     
==========================================
  Files          70       70              
  Lines        6182     6190       +8     
==========================================
+ Hits         4084     4087       +3     
- Misses       1839     1843       +4     
- Partials      259      260       +1     
Flag Coverage Δ
e2e 45.12% <62.50%> (-0.04%) ⬇️
unit 55.26% <75.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort tmshort added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Apr 23, 2025

Closing, not needed.

@tmshort tmshort closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants