🌱 Change how systemroot is created when SSL_CERT environment is set #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tmshort
added
the
do-not-merge/work-in-progress
tmshort
force-pushed
the
system-pool
branch
3 times, most recently
from
e4a6247 to
aedd2bd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
==========================================
+ Coverage 66.06% 66.14% +0.08%
==========================================
Files 70 70
Lines 6182 6238 +56
==========================================
+ Hits 4084 4126 +42
- Misses 1839 1849 +10
- Partials 259 263 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The x509.SystemCertPool() looks at the SSL_CERT_FILE and SSL_CERT_DIR environment variables to generate the pool. However, if the contents of the referenced file (singular) or directories (multiple) change, there is no guarantee that x509.SystemCertPool() will be updated. Since we are watching these locations (defined by the environment) via fsnotify, we want to ensure that when those files are updated that the cert pool we use is also updated. So, if SSL_CERT_FILE or SSL_CERT_DIR are defined, create our cert pool from those variable _only_, ignoring the x509.SystemCertPool(). This is how the x509.SystemCertPool() would be created, so we do it explicitly instead. This allows us to properly refresh the pool when fsnotify tells us there are changes to our watches. This does not impact images/containers (i.e. impage pulling) directly, since that still uses x509.SystemCertPool(), so it may get a stale pool, but the catalogd client will have an up-to-date pool. See: https://pkg.go.dev/crypto/x509#SystemCertPool Signed-off-by: Todd Short <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
tmshort
changed the title
|
closing, not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The x509.SystemCertPool() looks at the SSL_CERT_FILE and SSL_CERT_DIR
environment variables to generate the pool. However, if the contents of
the referenced file (singular) or directories (multiple) change, there
is no guarantee that x509.SystemCertPool() will be updated. Since we
are watching these locations (defined by the environment) via fsnotify,
we want to ensure that when those files are updated that the cert pool
we use is also updated.
So, if SSL_CERT_FILE or SSL_CERT_DIR are defined, create our cert pool
from those variable only, ignoring the x509.SystemCertPool().
This is how the x509.SystemCertPool() would be created, so we do it
explicitly instead. This allows us to properly refresh the pool when
fsnotify tells us there are changes to our watches.
This does not impact images/containers (i.e. impage pulling) directly,
since that still uses x509.SystemCertPool(), so it may get a stale pool,
but the catalogd client will have an up-to-date pool.
See: https://pkg.go.dev/crypto/x509#SystemCertPool
Reviewer Checklist