Skip to content

🌱 Add prometheus to e2e workflow #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Apr 17, 2025

Description

Closes #1902

Adds an additional e2e Makefile target which runs the e2e with prometheus deployed. This will allow us to check for alerts and potential performance degradation after e2e runs.

Starting out with just the minimal install as opposed to the entire kube-prometheus stack, which has far more than we need right now.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@dtfranz dtfranz requested a review from a team as a code owner April 17, 2025 16:24
@openshift-ci openshift-ci bot requested review from bentito and gavinmbell April 17, 2025 16:24
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 6c32ce6
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/680974efba85980008c19a04
😎 Deploy Preview https://deploy-preview-1928--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.97%. Comparing base (6d7af37) to head (6c32ce6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1928   +/-   ##
=======================================
  Coverage   65.97%   65.97%           
=======================================
  Files          71       71           
  Lines        6189     6189           
=======================================
  Hits         4083     4083           
  Misses       1846     1846           
  Partials      260      260           
Flag Coverage Δ
e2e 45.12% <ø> (-0.07%) ⬇️
unit 55.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor

tmshort commented Apr 18, 2025

So, this adds a new e2e that isn't run downstream? There's no workflow to run it in upstream CI?

@dtfranz
Copy link
Contributor Author

dtfranz commented Apr 21, 2025

So, this adds a new e2e that isn't run downstream? There's no workflow to run it in upstream CI?

Yes - it currently only adds prometheus to the environment when you run the new e2e target, so I've kept the workflow the same for now. If you'd prefer I'm happy to make that change here - it doesn't add much overhead to the e2e at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install Prometheus on e2e cluster
3 participants