Skip to content

Bentito helm poc #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented May 28, 2024

No description provided.

@dtfranz dtfranz requested a review from a team as a code owner May 28, 2024 19:28
bentito and others added 8 commits May 28, 2024 12:35
TestClusterExtensionChannelVersionExists mostly restored here

Signed-off-by: Brett Tofel <[email protected]>
In just one test, for now.

Signed-off-by: Brett Tofel <[email protected]>
Unskips all in clusterextension_controller_test.go

Signed-off-by: Brett Tofel <[email protected]>
Still failing tests (up|down)grade should err b/c we don't have an installedBundle to check against

Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Varsha Prasad Narsing <[email protected]>
@dtfranz dtfranz force-pushed the bentito_helm-poc branch from 22db881 to 3b21c1d Compare May 28, 2024 19:39
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 44.87179% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 58.52%. Comparing base (b993945) to head (507c86e).

Files Patch % Lines
internal/controllers/common_controller.go 51.02% 24 Missing ⚠️
...nternal/controllers/clusterextension_controller.go 26.92% 19 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           helm-poc     #894       +/-   ##
=============================================
- Coverage     76.08%   58.52%   -17.56%     
=============================================
  Files            18       11        -7     
  Lines          1154      991      -163     
=============================================
- Hits            878      580      -298     
- Misses          198      378      +180     
+ Partials         78       33       -45     
Flag Coverage Δ
e2e ?
unit 58.52% <44.87%> (+7.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort
Copy link
Contributor

tmshort commented May 29, 2024

Closing in favor of #874

@tmshort tmshort closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants