-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Bump k8s dependencies to 1.21+ #5057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
varshaprasad96
merged 7 commits into
operator-framework:master
from
varshaprasad96:bump/k8s-1.21
Jul 15, 2021
+606
−455
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cb08356
bump dependencies
varshaprasad96 657fa2f
fix go.mod and pin docker/distribution
varshaprasad96 5dd1d91
add kb assets to envtest
varshaprasad96 4b83e06
export kubebuilder_assets in makefile
varshaprasad96 b656934
fix lint
varshaprasad96 8bf53fb
fix envtest location in makefile
varshaprasad96 9d86eb1
fix molecule test
varshaprasad96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # entries is a list of entries to include in | ||
| # release notes and/or the migration guide | ||
| entries: | ||
| - description: > | ||
| (ansible/v1) Bumped Kuztomize version in ansible project scaffolding to 3.8.7. | ||
|
|
||
| # kind is one of: | ||
| # - addition | ||
| # - change | ||
| # - deprecation | ||
| # - removal | ||
| # - bugfix | ||
| kind: "change" | ||
|
|
||
| # Is this a breaking change? | ||
| breaking: true | ||
|
|
||
| # NOTE: ONLY USE `pull_request_override` WHEN ADDING THIS | ||
| # FILE FOR A PREVIOUSLY MERGED PULL_REQUEST! | ||
| # | ||
| # The generator auto-detects the PR number from the commit | ||
| # message in which this file was originally added. | ||
| # | ||
| # What is the pull request number (without the "#")? | ||
| # pull_request_override: 0 | ||
|
|
||
|
|
||
| # Migration can be defined to automatically add a section to | ||
| # the migration guide. This is required for breaking changes. | ||
| migration: | ||
| header: (ansible/v1) Bump Kuztomize version in helm project scaffolding to 3.8.7 | ||
| body: > | ||
| Ansible projects are now scaffolded with `Kuztomize` version `3.8.7`. This version of kustomize | ||
| requires that the path to patch file be provided with the `--path` flag in `add patch` command. | ||
| In `molecule/default/prepare.yml` file, update the command under `Set pull policy`, to be: | ||
| ```diff | ||
| - name: Set pull policy | ||
| - command: '{{ "{{ kustomize }}" }} edit add patch pull_policy/{{ "{{ operator_pull_policy }}" }}.yaml' | ||
| + command: '{{ "{{ kustomize }}" }} edit add patch --path pull_policy/{{ "{{ operator_pull_policy }}" }}.yaml' | ||
| ``` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving this for now, since
--generatorflag is deprecated here and the test needs to be re-written, in sdk and kubebuilder. Will do this in a follow up PR, as I didn't want to block updating of k8s in projects because of this.