Skip to content

Commit

Permalink
Fix #425: Update fraction rule parsing to use non-negative int instea…
Browse files Browse the repository at this point in the history
…d of double (#450)

* Update fraction rule parsing to use non-negative int instead of double.

* Address reviewer comment.
  • Loading branch information
BenHenning authored Nov 26, 2019
1 parent b5bc32b commit 240a3b2
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions domain/src/main/java/org/oppia/domain/util/StateRetriever.kt
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,16 @@ class StateRetriever @Inject constructor(
while (inputKeysIterator.hasNext()) {
val inputName = inputKeysIterator.next()
when (ruleSpecBuilder.ruleType) {
"HasDenominatorEqualTo", "HasNumeratorEqualTo" -> ruleSpecBuilder.putInput(
"HasNumeratorEqualTo" -> ruleSpecBuilder.putInput(
inputName,
InteractionObject.newBuilder()
.setReal(inputsJson.getDouble(inputName))
.setSignedInt(inputsJson.getInt(inputName))
.build()
)
"HasDenominatorEqualTo" -> ruleSpecBuilder.putInput(
inputName,
InteractionObject.newBuilder()
.setNonNegativeInt(inputsJson.getInt(inputName))
.build()
)
else -> ruleSpecBuilder.putInput(inputName, createExactInputFromJson(inputsJson, inputName, interactionId))
Expand Down

0 comments on commit 240a3b2

Please sign in to comment.