Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated protobuf version #4583

Closed
Smarshal21 opened this issue Sep 10, 2022 · 7 comments
Closed

Deprecated protobuf version #4583

Smarshal21 opened this issue Sep 10, 2022 · 7 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Smarshal21
Copy link

Describe the bug
Could not resolve all files for configuration ":model:protobufToolsLocator_protoc'

To Reproduce
Steps to reproduce the behavior:

  1. Go to the oppia android repository
  2. Clone the project to your system
  3. Try Running the app on your physical device/emulator
  4. See error

Expected behavior
The app should run perfectly with the updated protobuf version

Demonstration
Screenshot 2022-08-29 at 3 53 12 PM

Screenshot 2022-08-29 at 3 53 20 PM

Environment

  • Device/emulator being used: Pixel 5 API 33
  • Android or SDK version (e.g. Android 5 or SDK 21): 11
  • App version (you can get this through system app settings or via the admin controls menu in-app): 0.9-beta-3f935261e0
@Smarshal21
Copy link
Author

Hi @BenHenning,

I have found the solution of this bug for mac m1 chip.
Basically it's like for the older versions of the protobuf there is no executable jars for the mac m1 arm architecture so we need to update the protobuf version for the project so that we can also support arm based architecture chips.

Shall I make a Pull Request for this issue or do you like to further discuss about the solutions for this issue.

Thanks,
Samanwith

@BenHenning
Copy link
Member

Hi @BenHenning,

I have found the solution of this bug for mac m1 chip. Basically it's like for the older versions of the protobuf there is no executable jars for the mac m1 arm architecture so we need to update the protobuf version for the project so that we can also support arm based architecture chips.

Shall I make a Pull Request for this issue or do you like to further discuss about the solutions for this issue.

Thanks, Samanwith

Nice find @Samanwith21. Sure, we can try to update protoc, though it may cause issues with the Gradle build since that protoc setup has historically been finicky when we change versions.

@Smarshal21
Copy link
Author

@BenHenning
i have tried updating the protobuf and the app is running fine,
shall i create a PR depicting the solution ???

@BenHenning
Copy link
Member

@BenHenning i have tried updating the protobuf and the app is running fine, shall i create a PR depicting the solution ???

Yep @Samanwith21. CI will help indicate if everything is working as expected (particularly since we use both Gradle and Bazel for building, and both will need to be updated to move off of the old protoc version).

@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). issue_type_infrastructure Z-ibt Temporary label for Ben to keep track of issues he's triaged. labels Sep 14, 2022
@Smarshal21
Copy link
Author

@BenHenning can i get the access to push the changes into a new branch ?

@seanlip
Copy link
Member

seanlip commented Sep 15, 2022

You can make a PR the standard way. See instructions here.

@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added Work: Low Solution is clear and broken into good-first-issue-sized chunks. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Jun 8, 2023
@MohitGupta121 MohitGupta121 added Impact: Low Low perceived user impact (e.g. edge cases). and removed Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jun 27, 2023
@adhiamboperes
Copy link
Collaborator

This was fixed in #4675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

5 participants