Fix #4583: Deprecated Protobuf Version

[Smarshal21]

Explanation

• Fixes Deprecated protobuf version #4583:

• Basically it's like for the older versions of the protobuf there is no executable jars for the mac m1 arm architecture so this PR updates the protobuf version for the project so that we can also support arm based architecture chips.

• "This PR Fixes Deprecated protobuf version #4583:"

Essential Checklist

• The PR Protobuf updates the protobuf version in order to run the app successfully without any gradle and bazel issues.
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[BenHenning]

Thanks @Smarshal21. I left one high-level comment, but otherwise I think we need to wait for the CI run here.

You'll also need to update the Bazel build. For reference, see:

oppia-android/WORKSPACE

Line 149 in 1eebfb5

strip_prefix = "protobuf-%s" % HTTP_DEPENDENCY_VERSIONS["protobuf_tools"]["version"],

oppia-android/third_party/versions.bzl

Line 121 in 1eebfb5

"version": "3.11.0",

I'm also wondering whether we should consider introducing builds for the app on OS X to ensure that it builds correctly, as recent changes seem to periodically cause issues.

Finally, I'm updating this PR to be in 'draft' since it's not yet code complete.

[BenHenning]

I just started the CI run, so we'll need to see if it works, but will this artifact actually work non-OS X platforms?

[Smarshal21]

@BenHenning i have updated the build bazel

[BenHenning]

I don't think that addresses my question @Smarshal21. It seems like this updated Gradle file won't work for non-Linux platforms (which is completely separate from the Bazel builds).

[BenHenning]

Also @Smarshal21 please use the exact PR checklist & sections (if UI screenshots aren't relevant, you can leave a brief explanation for why but otherwise the section should still be there since reviewers specifically look for it).

[Smarshal21]

@BenHenning @seanlip ptal at the new commit , i have updated the build bazel

[oppiabot]

Unassigning @Smarshal21 since a re-review was requested. @Smarshal21, please make sure you have addressed all review comments. Thanks!

[BenHenning]

@Smarshal21 thanks for adding the Bazel change, but you'll need to build the app locally on both Gradle & Bazel to make sure it's working. Per the CI checks, it looks like the build isn't working on either build platform. PTAL at the CI checks to determine what needs to be changed in the PR.

[BenHenning]

I don't think that addresses my question @Smarshal21. It seems like this updated Gradle file won't work for non-Linux platforms (which is completely separate from the Bazel builds).

[oppiabot]

Hi @Smarshal21, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!