-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #1433: Introduce the Oppia Logger and move analytics logging to it #1499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Just had one suggestion regarding the logging of events in AnalyticsControllerTest.kt
domain/src/test/java/org/oppia/domain/oppialogger/analytics/AnalyticsControllerTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vinitamurthi--left a few comments, but overall the PR LGTM.
domain/src/main/java/org/oppia/domain/oppialogger/OppiaLogger.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/OppiaLogger.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/OppiaLogger.kt
Outdated
Show resolved
Hide resolved
@Sarthak2601 are you planning to provide additional feedback? Otherwise, you should de-assign yourself if you've finished reviewing the PR. |
PTAL @BenHenning and if the changes look okay can you resolve the comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vinitamurthi. The PR LGTM--feel free to resolve my comment directly once it's addressed or reassign this PR to me if you have follow-up questions.
Explanation
This PR adds the Oppia Logger. It moves the calls of the analytics controller methods to the oppia logger and adds tests
Fixes part of #1433
Checklist