Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #1433: Introduce the Oppia Logger and move analytics logging to it #1499

Merged
merged 17 commits into from
Jul 28, 2020

Conversation

vinitamurthi
Copy link
Contributor

Explanation

This PR adds the Oppia Logger. It moves the calls of the analytics controller methods to the oppia logger and adds tests
Fixes part of #1433

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@vinitamurthi vinitamurthi requested a review from Sarthak2601 July 22, 2020 06:35
@vinitamurthi vinitamurthi marked this pull request as ready for review July 22, 2020 06:35
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Just had one suggestion regarding the logging of events in AnalyticsControllerTest.kt

Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinitamurthi--left a few comments, but overall the PR LGTM.

@BenHenning
Copy link
Member

@Sarthak2601 are you planning to provide additional feedback? Otherwise, you should de-assign yourself if you've finished reviewing the PR.

@vinitamurthi
Copy link
Contributor Author

PTAL @BenHenning and if the changes look okay can you resolve the comments?

@Sarthak2601 Sarthak2601 removed their assignment Jul 24, 2020
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinitamurthi. The PR LGTM--feel free to resolve my comment directly once it's addressed or reassign this PR to me if you have follow-up questions.

@vinitamurthi vinitamurthi merged commit 5c5b8fc into develop Jul 28, 2020
@vinitamurthi vinitamurthi deleted the oppia-logger branch July 28, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants