Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5195: updated dependencies in build.gradle (module app) #5220

Closed

Conversation

sichchurov
Copy link
Collaborator

@sichchurov sichchurov commented Oct 31, 2023

Explanation

Fix #5195: updated dependencies in build.gradle (module app)

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@sichchurov sichchurov requested a review from a team as a code owner October 31, 2023 20:56
@sichchurov sichchurov changed the title Fix part of #5195: updated dependencies in build.gradle (module app) Fix #5195: updated dependencies in build.gradle (module app) Oct 31, 2023
@sichchurov
Copy link
Collaborator Author

@adhiamboperes, PTAL
Thanks

@sichchurov sichchurov marked this pull request as draft November 3, 2023 11:55
@sichchurov sichchurov marked this pull request as ready for review November 3, 2023 11:56
@sichchurov sichchurov marked this pull request as draft November 3, 2023 15:01
@sichchurov sichchurov closed this Nov 5, 2023
@sichchurov sichchurov deleted the issue#5195_invalid_package branch November 5, 2023 18:04
@adhiamboperes
Copy link
Collaborator

Hi @sichchurov, did you mean to close this PR?

@sichchurov
Copy link
Collaborator Author

Hello @sichchurov, do you want to close this PR?

Hello @adhiamboperes. Yes. The robolectric tests are not working after changing build.gradle. I will come back to this issue a little later. I want to finish my current task at work and take another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidPackage + NewApi + FragmentLiveDataObserve + RestrictedApi
2 participants