Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5273: UnusedAttribute Lint Warning #5623

Closed
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[*.{kt,kts}]
# possible values: number (e.g. 2), "unset" (makes ktlint ignore indentation completely)
indent_size=2
kotlin_imports_layout=idea

4 changes: 1 addition & 3 deletions .idea/codeStyles/Project.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions app/.idea/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

340 changes: 340 additions & 0 deletions app/.idea/caches/deviceStreaming.xml

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions app/.idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions app/.idea/migrations.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions app/.idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions app/.idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions app/local.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
## This file must *NOT* be checked into Version Control Systems,
# as it contains information specific to your local configuration.
#
# Location of the SDK. This is only used by Gradle.
# For customization when using a Version Control System, please read the
# header note.
#Sun Dec 29 14:30:24 IST 2024
sdk.dir=D\:\\Android
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@ import org.oppia.android.app.utility.datetime.DateTimeUtil
*
* Instances of this subcomponent should be created using [ActivityComponentFactory].
*/
interface ActivityComponent : AppLanguageActivityInjector, DateTimeUtil.Injector
interface ActivityComponent :
AppLanguageActivityInjector,
DateTimeUtil.Injector
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,14 @@ import org.oppia.android.app.walkthrough.WalkthroughActivity
@Subcomponent(
modules = [
ActivityModule::class, FragmentComponentBuilderModule::class,
ActivityIntentFactoriesModule::class
]
ActivityIntentFactoriesModule::class,
],
)
@ActivityScope
interface ActivityComponentImpl :
ActivityComponent, FragmentComponentBuilderInjector, TestActivity.Injector {
ActivityComponent,
FragmentComponentBuilderInjector,
TestActivity.Injector {
@Subcomponent.Builder
interface Builder {
@BindsInstance
Expand All @@ -122,108 +124,190 @@ interface ActivityComponentImpl :
}

fun inject(addProfileActivity: AddProfileActivity)

fun inject(adminAuthActivity: AdminAuthActivity)

fun inject(administratorControlsActivity: AdministratorControlsActivity)

fun inject(administratorControlsFragmentTestActivity: AdministratorControlsFragmentTestActivity)

fun inject(adminPinActivity: AdminPinActivity)
fun inject(
appCompatCheckBoxBindingAdaptersTestActivity:
AppCompatCheckBoxBindingAdaptersTestActivity
)

fun inject(appCompatCheckBoxBindingAdaptersTestActivity: AppCompatCheckBoxBindingAdaptersTestActivity)

fun inject(appLanguageActivity: AppLanguageActivity)

fun inject(appVersionActivity: AppVersionActivity)

fun inject(audioFragmentTestActivity: AudioFragmentTestActivity)

fun inject(audioLanguageActivity: AudioLanguageActivity)

fun inject(circularProgressAdaptersTestActivity: CircularProgressIndicatorAdaptersTestActivity)

fun inject(completedStoryListActivity: CompletedStoryListActivity)

fun inject(conceptCardFragmentTestActivity: ConceptCardFragmentTestActivity)

fun inject(developerOptionsActivity: DeveloperOptionsActivity)

fun inject(developerOptionsTestActivity: DeveloperOptionsTestActivity)

fun inject(dragDropTestActivity: DragDropTestActivity)

fun inject(drawableBindingAdaptersTestActivity: DrawableBindingAdaptersTestActivity)

fun inject(explorationActivity: ExplorationActivity)

fun inject(explorationInjectionActivity: ExplorationInjectionActivity)

fun inject(explorationTestActivity: ExplorationTestActivity)

fun inject(faqListActivity: FAQListActivity)

fun inject(faqSingleActivity: FAQSingleActivity)

fun inject(forceNetworkTypeActivity: ForceNetworkTypeActivity)

fun inject(forceNetworkTypeTestActivity: ForceNetworkTypeTestActivity)

fun inject(fractionInputInteractionViewTestActivity: FractionInputInteractionViewTestActivity)

fun inject(helpActivity: HelpActivity)

fun inject(homeActivity: HomeActivity)

fun inject(homeFragmentTestActivity: HomeFragmentTestActivity)

fun inject(homeTestActivity: HomeTestActivity)

fun inject(htmlParserTestActivity: HtmlParserTestActivity)

fun inject(imageRegionSelectionTestActivity: ImageRegionSelectionTestActivity)

fun inject(imageViewBindingAdaptersTestActivity: ImageViewBindingAdaptersTestActivity)

fun inject(inputInteractionViewTestActivity: InputInteractionViewTestActivity)

fun inject(textInputInteractionViewTestActivity: TextInputInteractionViewTestActivity)

fun inject(mathExpressionInteractionsViewTestActivity: MathExpressionInteractionsViewTestActivity)

fun inject(ratioInputInteractionViewTestActivity: RatioInputInteractionViewTestActivity)

fun inject(licenseListActivity: LicenseListActivity)

fun inject(licenseTextViewerActivity: LicenseTextViewerActivity)

fun inject(listItemLeadingMarginSpanTestActivity: ListItemLeadingMarginSpanTestActivity)

fun inject(markChaptersCompletedActivity: MarkChaptersCompletedActivity)

fun inject(markChaptersCompletedTestActivity: MarkChaptersCompletedTestActivity)

fun inject(markStoriesCompletedActivity: MarkStoriesCompletedActivity)

fun inject(markStoriesCompletedTestActivity: MarkStoriesCompletedTestActivity)

fun inject(markTopicsCompletedActivity: MarkTopicsCompletedActivity)

fun inject(marginBindableAdaptersTestActivity: MarginBindingAdaptersTestActivity)

fun inject(markTopicsCompletedTestActivity: MarkTopicsCompletedTestActivity)

fun inject(mathExpressionParserActivity: MathExpressionParserActivity)

fun inject(myDownloadsActivity: MyDownloadsActivity)

fun inject(navigationDrawerTestActivity: NavigationDrawerTestActivity)

fun inject(onboardingActivity: OnboardingActivity)

fun inject(ongoingTopicListActivity: OngoingTopicListActivity)

fun inject(optionActivity: OptionsActivity)

fun inject(pinPasswordActivity: PinPasswordActivity)

fun inject(policiesActivity: PoliciesActivity)

fun inject(policiesFragmentTestActivity: PoliciesFragmentTestActivity)

fun inject(profileAndDeviceIdActivity: ProfileAndDeviceIdActivity)

fun inject(profileChooserActivity: ProfileChooserActivity)

fun inject(profileChooserFragmentTestActivity: ProfileChooserFragmentTestActivity)

fun inject(profileEditActivity: ProfileEditActivity)

fun inject(profileEditFragmentTestActivity: ProfileEditFragmentTestActivity)

fun inject(profileListActivity: ProfileListActivity)

fun inject(profilePictureActivity: ProfilePictureActivity)

fun inject(profileProgressActivity: ProfileProgressActivity)

fun inject(profileRenameActivity: ProfileRenameActivity)

fun inject(profileResetPinActivity: ProfileResetPinActivity)

fun inject(questionPlayerActivity: QuestionPlayerActivity)

fun inject(readingTextSizeActivity: ReadingTextSizeActivity)

fun inject(recentlyPlayedActivity: RecentlyPlayedActivity)

fun inject(resumeLessonActivity: ResumeLessonActivity)

fun inject(revisionCardActivity: RevisionCardActivity)

fun inject(splashActivity: SplashActivity)

fun inject(splashTestActivity: SplashTestActivity)
fun inject(
stateAssemblerMarginBindingAdaptersTestActivity:
StateAssemblerMarginBindingAdaptersTestActivity
)

fun inject(
stateAssemblerPaddingBindingAdaptersTestActivity:
StateAssemblerPaddingBindingAdaptersTestActivity
)
fun inject(stateAssemblerMarginBindingAdaptersTestActivity: StateAssemblerMarginBindingAdaptersTestActivity)

fun inject(stateAssemblerPaddingBindingAdaptersTestActivity: StateAssemblerPaddingBindingAdaptersTestActivity)

fun inject(spotlightFragmentTestActivity: SpotlightFragmentTestActivity)

fun inject(stateFragmentTestActivity: StateFragmentTestActivity)

fun inject(storyActivity: StoryActivity)

fun inject(testFontScaleConfigurationUtilActivity: TestFontScaleConfigurationUtilActivity)

fun inject(textViewBindingAdaptersTestActivity: TextViewBindingAdaptersTestActivity)

fun inject(thirdPartyDependencyListActivity: ThirdPartyDependencyListActivity)

fun inject(topicActivity: TopicActivity)

fun inject(topicRevisionTestActivity: TopicRevisionTestActivity)

fun inject(topicTestActivity: TopicTestActivity)

fun inject(topicTestActivityForStory: TopicTestActivityForStory)

fun inject(viewBindingAdaptersTestActivity: ViewBindingAdaptersTestActivity)

fun inject(viewEventLogsActivity: ViewEventLogsActivity)

fun inject(viewEventLogsTestActivity: ViewEventLogsTestActivity)

fun inject(walkthroughActivity: WalkthroughActivity)

fun inject(surveyActivity: SurveyActivity)

fun inject(colorBindingAdaptersTestActivity: ColorBindingAdaptersTestActivity)

fun inject(classroomListActivity: ClassroomListActivity)

fun inject(onboardingProfileTypeActivity: OnboardingProfileTypeActivity)

fun inject(createProfileActivity: CreateProfileActivity)

fun inject(introActivity: IntroActivity)
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ interface ActivityIntentFactories {
* Returns a new [Intent] to start the topic activity for the specified profile, classroom
* and topic.
*/
fun createIntent(profileId: ProfileId, classroomId: String, topicId: String): Intent
fun createIntent(
profileId: ProfileId,
classroomId: String,
topicId: String,
): Intent

/**
* Returns a new [Intent] to start the topic activity for the specified profile, classroom,
Expand All @@ -31,7 +35,7 @@ interface ActivityIntentFactories {
profileId: ProfileId,
classroomId: String,
topicId: String,
storyId: String
storyId: String,
): Intent
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ import org.oppia.android.app.topic.TopicActivity
interface ActivityIntentFactoriesModule {
@Binds
fun provideTopicActivityIntentFactory(
impl: TopicActivity.TopicActivityIntentFactoryImpl
impl: TopicActivity.TopicActivityIntentFactoryImpl,
): ActivityIntentFactories.TopicActivityIntentFactory

@Binds
fun provideRecentlyPlayedActivityIntentFactory(
impl: RecentlyPlayedActivity.RecentlyPlayedActivityIntentFactoryImpl
impl: RecentlyPlayedActivity.RecentlyPlayedActivityIntentFactoryImpl,
): ActivityIntentFactories.RecentlyPlayedActivityIntentFactory
}
Loading
Loading