Skip to content

[FSSDK-11437] pass logger to all child components #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 18, 2025
Merged

[FSSDK-11437] pass logger to all child components #1028

merged 4 commits into from
Apr 18, 2025

Conversation

raju-opti
Copy link
Contributor

Summary

Test plan

  • added tests

Issues

  • FSSDK-11437

@coveralls
Copy link

coveralls commented Apr 16, 2025 •
edited
Loading

Coverage Status

coverage: 80.755% (-0.2%) from 80.991%
when pulling 57d7143 on raju/child_logger
into 1d4d290 on master.

junaed-optimizely
junaed-optimizely approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raju-opti raju-opti merged commit 85c0220 into master Apr 18, 2025
14 of 20 checks passed
@raju-opti raju-opti deleted the raju/child_logger branch April 18, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @junaed-optimizely