Skip to content

update: Updated typescript type specifications to use browser entry point #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2022
Merged

update: Updated typescript type specifications to use browser entry point #754

merged 3 commits into from
May 13, 2022

Conversation

zashraf1985
Copy link
Contributor

Summary

Some application were having a hard time finding http module being used in the node entry point. Changed the type specifications to point to browser entry point.

Test plan

All existing tests pass

Issues

#686

@coveralls
Copy link

coveralls commented Apr 15, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 97.185% when pulling 55870d5 on zeeshan/change-types into aa11535 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.185% when pulling 0be9a83 on zeeshan/change-types into e092f81 on master.

@zashraf1985 zashraf1985 marked this pull request as ready for review April 15, 2022 22:24
@zashraf1985 zashraf1985 requested a review from a team as a code owner April 15, 2022 22:24
opti-jnguyen
opti-jnguyen approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@opti-jnguyen opti-jnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though tests are failing (I assume due to SRE/travis issue?)

@zashraf1985 zashraf1985 closed this May 9, 2022
@zashraf1985 zashraf1985 reopened this May 9, 2022
@zashraf1985 zashraf1985 closed this May 9, 2022
@zashraf1985 zashraf1985 reopened this May 9, 2022
@zashraf1985 zashraf1985 reopened this May 12, 2022
@zashraf1985 zashraf1985 merged commit 4034c7d into master May 13, 2022
@zashraf1985 zashraf1985 deleted the zeeshan/change-types branch May 13, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opti-jnguyen opti-jnguyen opti-jnguyen approved these changes

Assignees

@zashraf1985 zashraf1985

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zashraf1985 @coveralls @opti-jnguyen