Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junaed/fssdk 10936 async storage dynamic import #972

Merged

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Dec 3, 2024

Summary

Test plan

  • Existing tests have been modified
  • New test cases added
  • Manual testing against metro bundler

Issues

@coveralls
Copy link

coveralls commented Dec 3, 2024

Coverage Status

coverage: 86.916%. remained the same
when pulling 6192b13 on junaed/fssdk-10936-async-storage-dynamic-import
into 16e638a on master.

Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@junaed-optimizely junaed-optimizely merged commit bbe7a5b into master Dec 3, 2024
16 of 19 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10936-async-storage-dynamic-import branch December 3, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants