Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jongsy/fix multiple experiment event params #135

Conversation

jongsy
Copy link

@jongsy jongsy commented Aug 21, 2018

No description provided.

@optibot
Copy link

optibot commented Aug 21, 2018

Can one of the admins verify this patch?

1 similar comment
@optibot
Copy link

optibot commented Aug 21, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.654% when pulling fb24235 on jongsy:jongsy/fix-multiple-experiment-event-params into 210e9c6 on optimizely:master.

@aliabbasrizvi
Copy link
Contributor

@jongsy thank you for submitting this fix. Taking a look at this. Can you please sign our CLA here: https://docs.google.com/a/optimizely.com/forms/d/e/1FAIpQLSf9cbouWptIpMgukAKZZOIAhafvjFCV8hS00XJLWQnWDFtwtA/viewform

@jongsy
Copy link
Author

jongsy commented Aug 21, 2018

@aliabbasrizvi No problem. I've signed the CLA

@aliabbasrizvi
Copy link
Contributor

Thanks @jongsy . I pulled your changes and merged them as part of #136 .

We will be publishing a new version of the SDK. I will respond here as soon as that happens.
Thank you again for flagging this issue and submitting a fix as well. Really appreciate it.

@aliabbasrizvi
Copy link
Contributor

@jongsy patched the issue and fix is available in SDK 2.1.1: https://pypi.org/project/optimizely-sdk/2.1.1

Thank you again for sending the fix over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants