Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac(ci): (adding python 3.7 support fix) use xenial #159

Closed
wants to merge 1 commit into from
Closed

refac(ci): (adding python 3.7 support fix) use xenial #159

wants to merge 1 commit into from

Conversation

juancarlostong
Copy link
Contributor

@juancarlostong juancarlostong commented Jan 7, 2019 •
edited
Loading

Summary

  • Adding python3.7 support. Ubuntu Trusty does not support this version so we have to use Xenial instead.

Note

@juancarlostong juancarlostong added the wip Work in progress label Jan 7, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.695% when pulling 6776691 on jctong/python-3.7-support into bbb8cc2 on oakbani/python-3.7-support.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.695% when pulling 6776691 on jctong/python-3.7-support into bbb8cc2 on oakbani/python-3.7-support.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.695% when pulling 6776691 on jctong/python-3.7-support into bbb8cc2 on oakbani/python-3.7-support.

@coveralls
Copy link

coveralls commented Jan 7, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 99.695% when pulling 597ad97 on jctong/python-3.7-support into bbb8cc2 on oakbani/python-3.7-support.

@juancarlostong juancarlostong force-pushed the jctong/python-3.7-support branch 3 times, most recently from 7b6d627 to b0f5aa1 Compare January 7, 2019 22:27
@juancarlostong juancarlostong force-pushed the jctong/python-3.7-support branch from b0f5aa1 to 597ad97 Compare January 7, 2019 22:39
@juancarlostong juancarlostong changed the title use xenial refac(ci): (adding python 3.7 support fix) use xenial Jan 7, 2019
@juancarlostong juancarlostong removed the wip Work in progress label Jan 7, 2019
@juancarlostong juancarlostong mentioned this pull request Jan 7, 2019
Merged
@aliabbasrizvi
Copy link
Contributor

Can you combine the changes here with #160?

@msohailhussain
Copy link
Contributor

@aliabbasrizvi Any one PR can be merged #159 or #160, I liked the approach in #160 to use xenial only for python 3.7. We may discard this one.

@aliabbasrizvi
Copy link
Contributor

I prefer #160 as well. We can close this out.

aliabbasrizvi
aliabbasrizvi suggested changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to revise so that you may close this.

@aliabbasrizvi aliabbasrizvi deleted the jctong/python-3.7-support branch January 9, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi requested changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juancarlostong @coveralls @aliabbasrizvi @msohailhussain